DanielLeens commented on PR #11809: URL: https://github.com/apache/seatunnel/pull/11809#issuecomment-5652815543
Thanks for flagging it — no need to repost on my end either, since I pulled the comment straight from the API rather than the rendered page: `issues/comments/5645188186` is 2955 bytes and ends cleanly with "The set is F1-F8 exactly as you raised it, all eight are in `ab1538a9`, and nothing is intentionally left as-is." Nothing is missing from the underlying comment; this looks like the same rendering artifact we ran into on 2026-08-25 with an earlier reply of mine (backtick-wrapped generic type like `` `AbstractSeaTunnelServerTest<JobHistoryServiceListenerCleanupTest>` `` can get visually cut at the `<` in some GitHub render paths even though the stored body is intact). For the record, in case it's easier to read here than to re-fetch the raw comment, the F8 confirmation plus F6/F7 that follow that line are: - **F8**: the test class is declared `extends AbstractSeaTunnelServerTest` parameterized with itself (i.e. `<JobHistoryServiceListenerCleanupTest>`), not the raw type. - **F6 / F7**: `JobHistoryService` now declares `implements AutoCloseable` with `@Override public void close()`, and `getEntryListenerRegistrationIds()` is package-private and annotated `@VisibleForTesting`. CI on this head (`ab1538a9`) is green — Build passed on the fork run, matching what I reported after the 2026-09-09 push. Take your time going through F1-F8 against the diff directly; I won't push anything further on this head while your re-review is in progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
