SEPURI-SAI-KRISHNA commented on PR #12290: URL: https://github.com/apache/seatunnel/pull/12290#issuecomment-5653039874
Thanks for the review, and for catching the history error. You are right and I have corrected the description. #11937 is "[Fix][Transform-V2] Handle TINYINT and SMALLINT in Zeta SQL numeric functions" and has nothing to do with `HashUtils`; it touches `NumericFunction` and the SQL function docs. I checked its file list to confirm rather than just taking the correction. #11987 migrated the other call sites itself when it introduced the helper, and #12049 did the AzureCosmosDB enumerator, so those are the two the description should have named. On your reachability trace for `bucketCount == 0`: that matches what I found. The random-routing branch calls `random.nextInt(blockingQueues.size())` first, so a writer with an empty queue list is already broken before this line is reached, and the change only alters which exception a path that cannot be entered would throw. On CI: the fork run is still going, and I would rather let it finish than rerun into what looks like a bad window. The failures so far are not specific to this change. They overlap almost exactly with the ones on my other open PR #12182, which is a test-only change in `seatunnel-transforms-v2` and shares no code with this one: `all-connectors-it-6`, `all-connectors-it-7` and `paimon-connector-it` all failed on both, on both JDK legs. Where I have read the logs, the causes are environmental rather than assertions. `paimon-connector-it` failed before any test ran, with `Could not transfer artifact org.apache.commons:commons-lang3:jar:3.5 from/to central` and `The build could not read 2 projects`. `all-connectors-it-7` failed on `ContainerFetchException: Can't get Docker image: minio/minio:RELEASE.2024-06-13T22-53-53Z`. This run also lost `Run / Dead links`, which only checks URLs. A one line swap to a helper in `seatunnel-api` cannot reach any of those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
