nzw921rx commented on PR #12290:
URL: https://github.com/apache/seatunnel/pull/12290#issuecomment-5757985099

   > CI is down to one job after the sync, and it is not reachable from this 
diff.
   > 
   > The sync cleared the MinIO family for good, as expected once #12302 
landed. Failed legs went from seven before the sync, to four, to two legs of a 
single job now: engine-v2-it.
   > 
   > That job failed a different test each time. Attempt 1 was 
BackpressureSlowSinkIT.testCheckpointsKeepCompletingUnderSustainedBackpressure:247,
 attempt 2 was 
SplitClusterFaultToleranceIT.testStreamJobCancelResolvesWhenWorkerCrashesBeforeCancelAck:449,
 both Awaitility ConditionTimeout, both read from the JDK 8 leg. A different 
timeout each run points at runner load rather than one broken test, so I have 
stopped rerunning it.
   > 
   > It is also not specific to this PR. #12403 has engine-v2-it red on both 
legs too, and that change adds AES SQL functions in seatunnel-transforms-v2 
plus docs, touching nothing under seatunnel-engine.
   > 
   > For completeness on the diff itself: (object.hashCode() & 
Integer.MAX_VALUE) % blockingQueues.size() becomes 
HashUtils.bucketIndex(object.hashCode(), blockingQueues.size()), and that 
method's body is return (hash & Integer.MAX_VALUE) % bucketCount;. Routing is 
identical for any queue count above zero, and the only difference is which 
exception an unreachable zero-queue path would throw.
   > 
   > @nzw921rx this has had @DanielLeens's approval since 09-14 and is green 
everywhere except that one job, if you are happy to take it.
   
   Please wait dev fixed, then rebase? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to