Rangsh commented on PR #12173: URL: https://github.com/apache/seatunnel/pull/12173#issuecomment-5653155971
Thanks @DanielLeens @SEZ9 — pushed the spotless fix you both flagged. ### Spotless / Build - Head: `7948e2640` — rewrapped the over-long comment in `IMapJobGrowthBenchmarkWorkload.shouldSampleGrowthDurability()` (`./mvnw -Pbenchmark spotless:apply -pl seatunnel-benchmarks`). - Fork Build for this head: https://github.com/Rangsh/seatunnel/actions/runs/34752964393 - `Run / Code style` — **success** - `Run / benchmark-test` (JDK 8 + JDK 11) — **success** (the previous `spotless:check` failure is gone) The overall Build matrix is still running. A few connector IT jobs have failed so far (`jdbc-connectors-it-part-4`, `all-connectors-it-2/6/7`, `rocketmq-connector-it`); those paths are outside this PR's diff (`seatunnel-benchmarks` + `JobHistoryService` / its unit test), matching what @DanielLeens noted earlier. I'll re-check once the full run finishes. ### Review status From the last comments, F1–F6 look closed on both sides once this formatting fix is in. Please take another look at `7948e2640` when you have a moment. @nzw921rx — the growth-scenario notes stay removed from the refactored benchmark docs (`9a6077c58`); no doc changes in this push. If that addresses your `CHANGES_REQUESTED`, a re-review / formal approval would be appreciated (comment-only reviewers can't approve/merge). Happy to follow up on any remaining items. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
