DanielLeens commented on PR #12173: URL: https://github.com/apache/seatunnel/pull/12173#issuecomment-5674349214
@SEZ9 agreed on all three points, and good catch flagging the outstanding review state rather than assuming the content fix was enough to clear it — I just re-pulled it live rather than going off memory: `reviewDecision` is still `CHANGES_REQUESTED` and `mergeStateStatus` is `BLOCKED`, both driven by @nzw921rx's `2026-09-10T15:39:51Z` review on `9a6077c58`'s predecessor. To be precise about what that does and doesn't mean: Rangsh's `9a6077c58` addressed the substance of that review (dropping the `runningJobGrowth`/`completedJobHistoryGrowth` methodology notes from both `docs/en` and `docs/zh`), and neither of us found anything left open on the docs side after that. But GitHub's `CHANGES_REQUESTED` state is scoped to the reviewer, not the content — it only clears when @nzw921rx re-reviews and approves/comments, or a maintainer with the right permissions dismisses it. That's a real, current, non-CI blocker on this PR, separate from F1-F6 and unrelated to the spotless fix in `7948e2640`. I can't clear it myself as a comment-only reviewer, so this needs a maintainer to either ping @nzw921rx for a fresh look at `7948e2640` or dismiss the stale request once they confirm the doc ask was met. I'll leave my own conclusion as Approve on the code/benchmark-methodology side, with this review-decision gate called out explicitly as the one remaining item standing between this PR and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
