SEZ9 commented on PR #11545: URL: https://github.com/apache/seatunnel/pull/11545#issuecomment-5659049135
Thanks for the follow-up — the Surefire/Failsafe confirmation via the shared `surefire.jvm.args` / `argLine` property and the compile-phase finding both make sense. On the compile-phase gap: the reasoning holds. `argLine` only reaches the forked test JVMs, and the workflow-level env var was what let in-process javac see `sun.security.krb5` for the two connectors that import it directly. Scoping that export to the `maven-compiler-plugin` config of `connector-kudu` and `connector-paimon` keeps the flag next to the code that needs it rather than injecting it into every JVM in CI, which is what the `backend.yml` concern was about. A few remaining asks before I can sign off on this part: 1. Could you share the final `maven-compiler-plugin` configuration from `67da78738c` for both modules? I want to confirm whether the `--add-exports=java.security.jgss/sun.security.krb5=ALL-UNNAMED` argument is applied unconditionally or gated on a JDK 9+ profile, since on JDK 8 javac will reject it as an unrecognized option — the same class of problem raised for `config/jvm_options` on a leftover JDK 8. 2. Please confirm that after `67da78738c` there is no remaining `JAVA_TOOL_OPTIONS` in `backend.yml`, so those jobs run on a plain JDK 11/17 and the `Picked up JAVA_TOOL_OPTIONS` stderr noise is gone. 3. On `upgrade_compatibility.yml`: agreed that it is an independent workflow and not a duplicate of the Surefire profile. The earlier point still stands, though — it starts the old 2.3.13 release on JDK 17 with only the krb5 export, and that release's bundled `config/jvm_*_options` do not contain the new `--add-opens` set. Either that scenario has been verified to start cleanly (please say how), or it should be documented in the PR as a known limitation of the compatibility test. Leaving the file untouched is fine; leaving the question open is not. Once those are covered I think the `backend.yml` / test-profile portion of the review is resolved. <!-- streview-comment:1039 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
