SEZ9 commented on PR #11545:
URL: https://github.com/apache/seatunnel/pull/11545#issuecomment-5747474860
Thanks for the follow-up on `2c87f42f2b2`. Checking it against my earlier
points:
- **PR11545-F5 (Java version pre-check)** – the latest review on this head
notes a fail-fast Java version check in the launchers, which is what I asked
for. Please confirm it runs before any `--add-opens` flag reaches the JVM in
every launcher script and reports the minimum required version instead of the
raw `Unrecognized option` error.
- **PR11545-F3 / F6 / F8 (blanket `ALL-UNNAMED` opens, workflow-level
`JAVA_TOOL_OPTIONS`)** – `67d5410bfb5` ("Scope JDK 9+ module-opens flags to the
JVMs that need them") is the right direction. However, the latest review says
the test-JVM re-plumbing in `67d5410bfb` "currently breaks the default reactor
and the JDK 17 unit-test lane" and leaves two carryover items open, but the
details are cut off. Could you post those two items and describe how the
test-JVM flags are injected now (still via workflow-level `JAVA_TOOL_OPTIONS`
in `backend.yml`, or something else)? I need that to close F6/F8.
- **PR11545-F1 (module flags only in user-overridable
`config/jvm_*_options`)** – still open. The `incompatible-changes.md` entry
helps, but I'd still like either the mandatory flags applied by the launcher
regardless of the config directory, or an explicit startup warning when a
preserved config is missing them.
- **PR11545-F2 (Kerberos reflective reload failing silently)** – still open.
A logged warning when the reload fails because `--add-opens`/`--add-exports`
are missing would be sufficient.
- **PR11545-F4 / F7 (`upgrade_compatibility.yml` running the old 2.3.13
release on JDK 17)** – still open. Please either run the old release on JDK 11
with its bundled config, or add a note explaining why the jgss export alone is
enough for it to start.
Once those are addressed I'll do a final pass.
<!-- streview-comment:1186 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
