Vivek1106-04 commented on PR #12165: URL: https://github.com/apache/seatunnel/pull/12165#issuecomment-5691790692
@nzw921rx Opened the STIP as requested: **[STIP-40][Improve][Zeta] Member-wide shared checkpoint trigger scheduling** - https://github.com/apache/seatunnel/issues/12339 It covers Background, Motivation, Goals, Non-Goals, Design, Compatibility, Test Plan, Alternatives and References, and carries the thread-ownership and dispatch diagrams. Two things I flagged there rather than smoothed over, since they are the parts that need the list's opinion: - **Bounding the dispatch pool.** #12122 asks for a shared *bounded* scheduler. The timer pool is bounded; the dispatch pool currently is not. Bounding it properly means picking a rejection policy, and every candidate has a cost: caller-runs pushes checkpoint work back onto a timer thread and reintroduces the head-of-line blocking this design removes, an unbounded queue trades threads for latency and memory, and a bounded queue needs agreement on what a member should do when it cannot trigger a checkpoint on time. This is the main open question in the proposal. - **Timer pool size as a constant vs. an `Option`.** No strong view from me; I will follow the list. Two asks: 1. I do not have permission to add the `design` label to the issue. Could a committer add it so it shows up in the STIP list? 2. I will post the proposal to `[email protected]` next, linking the issue. Treating this PR as the candidate implementation for STIP-40, not as an accepted design. Happy to hold it until the STIP discussion concludes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
