Vivek1106-04 commented on PR #12165:
URL: https://github.com/apache/seatunnel/pull/12165#issuecomment-5776803803
Follow-ups filed, so the "tracked separately" wording in the class Javadoc
and in STIP-40
points at something real rather than an intention:
- **#12441** - `startSavepoint` holds the coordinator lock across its
sleep-poll, blocking
concurrent checkpoint triggers. Written up with both directions from this
review: move the
wait outside the lock (fixes it for `dev` too), or `tryLock` plus
reschedule in the dispatch
body (smaller, stays inside this PR's scheduler). The Javadoc on
`SharedCheckpointScheduler`
now cites it by number, in `c773cc091`.
- **#12442** - an unexpected throw in `tryTriggerPendingCheckpoint` silently
stops periodic
checkpointing for a pipeline. @nzw921rx, this is the follow-up I promised
on your rejection
thread; @DanielLeens traced the before/after visibility difference, which
is recorded there.
Pre-existing on `dev` and not made worse here.
Neither is claimed as fixed by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
