Nikk8091 opened a new pull request, #12352:
URL: https://github.com/apache/seatunnel/pull/12352

   ### Purpose of this pull request
   
   This PR handles the approved `connector-sls` source-and-sink validation 
slice of #11007.
   
   It adds declarative `notBlank` validation for the five existing required 
string options in both factories:
   
   - `endpoint`
   - `project`
   - `logstore`
   - `access_key_id`
   - `access_key_secret`
   
   The change is limited to factory-verifiable configuration eligibility. 
Optional options, defaults, cursor/start-mode behavior, client construction, 
credentials, networking, and source/sink runtime behavior remain unchanged.
   
   ### Does this PR introduce any user-facing change?
   
   Yes. Missing, empty, and whitespace-only values for the five required 
options are rejected during factory configuration validation for both the 
source and sink. Nonblank values, including values with surrounding spaces, 
remain accepted.
   
   The English and Chinese source and sink documentation now states that these 
required options cannot be empty or whitespace-only.
   
   ### How was this patch tested?
   
   Replaced the placeholder factory test with focused source-and-sink 
validation coverage for:
   
   - valid configurations;
   - all five required values with surrounding spaces;
   - each required option when missing;
   - each required option when empty;
   - each required option when whitespace-only.
   
   Validation performed with JDK 11:
   
   - `mvnw -pl seatunnel-connectors-v2/connector-sls spotless:apply`: passed;
   - `mvnw -pl seatunnel-connectors-v2/connector-sls -DskipITs verify`: passed;
   - `SlsFactoryTest`: 4 tests, 0 failures, 0 errors, 0 skipped;
   - `git diff --check`: passed.
   
   ### Checklist notes
   
   - No new dependency was added.
   - No remote SLS service is contacted by the tests.
   - No connector registration, distribution, E2E, credential, network, client, 
cursor, start-mode, source runtime, or sink runtime behavior was changed.
   - This PR contains only the approved SLS connector scope from #11007.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to