Nikk8091 commented on PR #12352:
URL: https://github.com/apache/seatunnel/pull/12352#issuecomment-5725546633

   Confirmed and updated:
   
   - `endpoint`, `project`, `logstore`, `access_key_id`, and 
`access_key_secret` were already required string options in both factories. 
This PR does not change their required/optional status or type and introduces 
no new option.
   - The branch has been rebased onto the latest `dev` at `c7304ace`; the 
rebased contribution commit is `8ebdf5ef`.
   - The surrounding-spaces cases confirm the existing `notBlank` behavior: 
nonblank strings with surrounding spaces remain accepted. No trimming or value 
transformation was added to the source or sink code.
   - After rebasing, `mvnw -pl seatunnel-connectors-v2/connector-sls -DskipITs 
verify` passed with 4 tests, 0 failures, and 0 errors.
   
   I added these confirmations to the PR description as requested. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to