SEZ9 commented on issue #11735: URL: https://github.com/apache/seatunnel/issues/11735#issuecomment-5707925135
Thanks for the update — using `SubPlan.pipelineRestoreNum` as the single durable attempt counter, atomic deduplication, the 4 KiB / 64 KiB limits for messages and stack traces, and a single bounded finished-job snapshot address the main review points raised above, and the v1 scope (pipeline-attempt grouping, optional task/worker attribution, keeping the existing `errorMessage` contract intact, best-effort persistence) looks reasonable. Two small things that would help review of #11734: - For the finished-job snapshot, could you note how it is expected to interact with the existing finished-job expiry so the master-side memory footprint stays bounded when many restores retain full stack traces? - Could you confirm the new history is additive-only, so existing job-detail REST clients are unaffected? Regarding assignment and the feature/design labels: I'll leave that to a maintainer with the necessary permissions to handle. <!-- streview-comment:1117 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
