SEZ9 commented on issue #11735: URL: https://github.com/apache/seatunnel/issues/11735#issuecomment-5842239819
@goutamadwant Thanks for the `a986eb16` revision and the updated STIP body. The "Normative Rules" tables and the list of changes since `e944f1e3` make the open points much easier to review. On wire compatibility: pinning both UIDs and asserting against fixtures written by the unmodified classes on current `dev`, with no field added, is the right scope for that slice. Its build is currently failing, so please resolve or document that failing result on the same head before it moves forward. When the later slice adds fields, keep these fixtures and add tests in both directions (old bytes read by the new class, and new bytes read by the unmodified class). Before the failure-history implementation slice, please list the acceptance tests that cover criteria 11–13, 20, 22, 24 and 34–37, and keep that work in independent slices after the compatibility change lands, separate from retry-policy or restore-scheduling changes. <!-- streview-comment:1316 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
