JeremyXin commented on PR #12169:
URL: https://github.com/apache/seatunnel/pull/12169#issuecomment-5713841370
@DanielLeens Thanks for the detailed review. We addressed the remaining
points as follows:
1. `dynamic-slot` is a single Engine-level setting in `seatunnel.yaml`,
and the current deployment model assumes consistent configuration across
Workers. `WorkerProfile.dynamicSlot` is runtime metadata, not an indication
that mixed slot modes are supported.
2. A tag-filter mismatch is intentionally not recorded as a generic
resource shortage, since adding Workers does not necessarily resolve a tag
constraint.
3. `ResourceManager` and `AutoscalerStateStore` are internal server-side
contracts rather than public extension SPIs. All in-tree implementations are
updated; no default methods are added.
4. Added concise lifecycle transition documentation to
`AutoscalingStateTracker.evaluate()`.
5. Added `ACCEPTED`, `DUPLICATE`, and `REJECTED` semantics to
`RecommendationPublisher.publish()`.
6. Periodic recommendation repeat remains intentionally disabled to avoid
duplicate downstream scaling actions. Recommendations are edge-triggered when
entering `FIRING`;
The remaining Build check failure will be investigated and rerun
separately before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
