NganWave commented on PR #11496: URL: https://github.com/apache/seatunnel/pull/11496#issuecomment-5716961720
@SEZ9 Thanks for reviewing! Some of the issues you mentioned above have already been addressed in my last push. I'll address the remaining ones below: **F2 (withFallback leaking -i values)**: The `withFallback(cleanSourceConfig)` logic has been removed and replaced with `processVariablesMap` and `originalResolvedConfigMap.keySet().removeIf(key -> !originalRootKeys.contains(key))`, which prevents any -i values from leaking into the final config. **F4 / F5 (System.setProperty no longer called)**: This removal was intentional. It fixes the issue of parsing user variables separately and avoids cross-job contamination. Since the previously released documentation in `config.md` never mentioned this behavior, I believe the internal implementation detail does not need to be documented. **F6 / F8 (quote heuristic and silent swallowing)**: These have been addressed in my last push. The fail-fast check for unbalanced braces/brackets and unterminated quotes has been restored, along with the corresponding unit tests. For the remaining questions (F1, F3, F7, and the new issue in the latest commit), I will add unit tests and docs and push the fixes next time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
