SEZ9 commented on issue #12353: URL: https://github.com/apache/seatunnel/issues/12353#issuecomment-5724605437
Thanks for checking #12311. Since it already changes a lost CANCELING vertex to CANCELED, adds a state-mapping unit test, and keeps the existing crash-before-ack E2E assertion, it makes sense to treat it as the implementation for this issue rather than duplicating it. For the additional coverage (worker failure before cancellation -> `FAILED`; cancellation accepted before the worker failure -> `CANCELED`; and the crash-before-cancel-ack path including checkpoint cancellation and error reporting), I would prefer to have them added to #12311 so the fix and its regression tests land together. If the author of #12311 would rather keep that PR narrow, a separate tests-only follow-up referencing this issue is fine as well; please coordinate on that PR so the two do not diverge. Could you also link this issue from #12311 so the history is easy to follow? <!-- streview-comment:1138 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
