SEZ9 commented on PR #10808: URL: https://github.com/apache/seatunnel/pull/10808#issuecomment-5724652703
Thanks for the follow-up in `f8ad576` — restoring the split-enumerator / barrier-flow files to match `dev` and removing `BarrierFlowOperationTest.java` resolves the blocker from the `cd8c818017` round and keeps this PR focused on the routing change. That concern is closed from my side. Since the routing core is unchanged from the earlier review, the previously raised points still stand. The ones I'd consider required before merge: 1. **Coordinator fallback in `ServerExecuteCommand`** — the "first non-lite member" fallback is a client-side guess and can disagree with the server's actual active coordinator. Please resolve the coordinator through the same server-side source the runtime uses, or make the fallback clearly best-effort in the output. 2. **`incompatible-changes.md`** — please add the CLI member-list `ACTIVE MASTER` semantics change for separated clusters. 3. **`telemetry.md`** — state the actual value of the "bounded timeout" for the final cancel-time metrics flush and whether it is configurable. Smaller items that could land in the same push: 4. When no active coordinator can be resolved, avoid silently labelling every non-lite member `MASTER`; an explicit "coordinator unknown" marker would help operators. 5. In `incompatible-changes.md`, note the standby/failover window in which no node reports as active coordinator for `isMaster` / `cluster_info`. 6. In `rest-api-v1.md`, a short note that the new `nodeRole` / `coordinator` / `worker` fields expose cluster topology on an endpoint that is unauthenticated by default. 7. Nit in `ServerExecuteCommandTest`: replace the inline fully-qualified `java.util.Collections` with an import. Once those are in I'll do a final pass on the head. <!-- streview-comment:1139 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
