Nikk8091 commented on PR #12315: URL: https://github.com/apache/seatunnel/pull/12315#issuecomment-5725546418
Confirmed: - #12315 is limited to the `SensorsDataSDKSinkFactory` option registration/validation change and the focused `SensorsDataSDKFactoryTest` coverage described in the PR. No unrelated connector or runtime code is touched. - The existing EN/ZH SensorsData documentation was verified to already match this contract (`server_url` required; `consumer` optional with the `batch` default), so no unnecessary documentation file change was made. - The PR targets `dev`, and its description links back to #11007. I will keep further SensorsData scope and review discussion on #12315. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
