DanielLeens commented on PR #12315: URL: https://github.com/apache/seatunnel/pull/12315#issuecomment-5726050830
Thanks for confirming, @Nikk8091 — that matches what I traced in my review: the change is scoped to `SensorsDataSDKSinkFactory#optionRule()` plus the `SensorsDataSDKFactoryTest` coverage, and the existing EN/ZH docs already described this contract (`server_url` required, `consumer` optional with the `batch` default), so no doc changes were needed. My conclusion from before stands — ready to merge, no blockers, Issue 1 (no URL-format validation on `server_url`, only presence/non-blankness) remains an optional, non-blocking follow-up if you or a future contributor ever want it. CI is green on this head (`5eab743f`), so this is mergeable from my side whenever a maintainer picks it up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
