junjunclub commented on issue #10681: URL: https://github.com/apache/seatunnel/issues/10681#issuecomment-5754510526
@SEZ9 Thanks for the review! Just to clarify the current state, Layer 0 and the shared Layer 1 framework have already been implemented and merged: * #10763 — Layer 0 (`--dry-run static`) * #11186 — Layer 1 (`--dry-run connect`) During the review of #11186, we discussed the SPI shape and eventually moved the dry-run hooks out of `TableSourceFactory` / `TableSinkFactory` into separate opt-in interfaces: * `SupportSourceDryRunValidation` * `SupportSinkDryRunValidation` Connectors that do not implement these interfaces are reported as `SKIPPED`, rather than failing the whole connect dry-run. `DryRunConnectValidator` already uses these shared hooks to orchestrate source → transform → sink validation. From what I can see, #12399 and #12400 are already building on these existing Layer 1 interfaces for MongoDB source and Kafka sink respectively, which matches the connector-by-connector rollout discussed in #11186. I’m happy to coordinate with @goutamadwant on any integration details or changes needed to the shared SPI. For the remaining questions, `--check` is currently kept as the compatibility path for static validation, while `--dry-run connect` runs through the CLI validation path without submitting a cluster job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
