SEZ9 commented on issue #10681: URL: https://github.com/apache/seatunnel/issues/10681#issuecomment-5770193412
@junjunclub Thanks for tracking the Layer 1 support matrix here — that's very helpful for coordinating the connector-by-connector rollout. Please go ahead with Redis Source and Sink. I'm not aware of anyone else working on it, and the scope you outlined is exactly what I'd want for this slice: - Build only on `SupportSourceDryRunValidation` / `SupportSinkDryRunValidation`, with no changes to `DryRunConnectValidator` or the shared SPI. - Bounded connectivity/authentication checks for both single-node and cluster modes, closing every client on success and failure. - No key reads, scans, writes, or other mutation during validation. - Source schema inferred from the configured schema / `table_configs` rather than inspecting Redis values. A few concrete asks for the PR: 1. Keep source and sink together in one focused PR so the review scope stays small. 2. Include tests covering both the success path and authentication/connection-failure paths. 3. Update the EN and ZH Redis connector docs alongside the code. 4. Link the PR back to this issue when it's open, and add it to the "In progress" section of the matrix above so the list stays current. Also, thanks for the notes on the scoped validation for Kafka Source and S3File Source — please keep that kind of "what is and isn't proven" statement in the Redis docs as well, so users know what `--dry-run connect` actually guarantees for that connector. @goutamadwant — the MongoDB Source (#12399) and Kafka Sink (#12400) work is already reflected in the matrix above; if any shared SPI adjustments come up during those reviews, please raise them here so the Redis work can stay aligned. <!-- streview-comment:1219 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
