TianHengZhuang commented on PR #12404: URL: https://github.com/apache/seatunnel/pull/12404#issuecomment-5809780465
Thank you for the detailed re-review @DanielLeens! Understood on both remaining issues. Here's my plan:\n\n**Issue 1 (Medium) - incompatible-changes.md:** I'll add a ## dev entry under connector-fake listing the newly rejected values (split.num <= 0, negative ow.num/sizes, ector.dimension <= 0, inary.vector.dimension <= 0, inverted min/max pairs). Will also clarify that ow.num = 0 stays valid.\n\n**Issue 2 (Medium) - Spotless:** Will run spotless:apply and push the formatted result. Noted the exact hunks you flagged.\n\nWill address both and push in one commit. Thanks again for the thorough reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
