TianHengZhuang commented on PR #12404: URL: https://github.com/apache/seatunnel/pull/12404#issuecomment-5859947585
Both blockers from your last review are now closed on `52cf8a70`: 1. `Run / Code style` is fully green - I ran `spotless:apply` locally and committed the exact output, so the trailing hunks are gone. 2. The corrupted Chinese line is rewritten cleanly (whole paragraph replaced, not byte-patched), and the incompatible-changes entries (en + zh) now list the complete set instead of only `split.num` / vector dimensions: `split.num` / `vector.dimension` / `binary.vector.dimension` (> 0); `row.num` / `split.read-interval` / `map.size` / `array.size` / `bytes.length` / `string.length` (>= 0); plus the seven `min <= max` pairs. `unit-test` also ran for the first time on this PR - 556 tests, 1 error: `SavePointTest.testSavePointButJobGoingToFail` (ConditionTimeout in `seatunnel-engine-server`, unrelated to this diff). `updated-modules-integration-test-part-1 (8, ubuntu)` failed on a Maven artifact download (`kr.motd.maven:os-maven-plugin`), also unrelated. Both look like infrastructure/flakiness rather than code, so I've re-run the failed jobs. Thanks again for the detailed review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
