DanielLeens commented on PR #12430: URL: https://github.com/apache/seatunnel/pull/12430#issuecomment-5812709221
Thanks for the update and the clear summary of what changed! I re-checked the head commit directly (rather than taking the summary on faith) — the `SafeValidationException` wrapper correctly narrows the exception-message discard to only the two safe, self-thrown structural errors, and the new test asserting `getSuppressed().length == 0` under an injected `session.close()` failure gives it real regression-catching power. This closes my previous Issue 1. Posting a full re-review below with the rest of my findings on the current head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
