DanielLeens commented on PR #12430: URL: https://github.com/apache/seatunnel/pull/12430#issuecomment-6109428694
Quick status update for @goutamadwant on head `5879969f8`, which has not changed since my last review. - **CI: now green.** In my last review the apache-side `Build` was still in progress and the fork run was queued. That is out of date: fork run `38089996882` (`goutamadwant/seatunnel`) completed successfully for this exact head (Code style, License header, Dead links, Sanity check, unit-test on 11/17 for Ubuntu and Windows, and updated-modules-integration-test-part-1 on 11/17), and the apache-side `Build` now reports SUCCESS. - **Merge state changed.** I reported the conflict as cleared and the head as 0 behind `dev`. `dev` has moved since then, and GitHub now shows this PR as conflicting (13 commits behind `dev`). Please sync with the latest `dev` again; the files most likely to conflict are the `docs/*/engines/zeta/user-command.md` tables that other dry-run PRs also edit, so keep both sides' rows. After the sync, only the new head will need CI. - **Still the same:** the PR is a draft, and it needs to be marked ready for review before it can be merged. My source-side conclusion is unchanged: no open source issues from my review, so this is not an approval yet only because of the merge conflict and draft state. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
