SEZ9 commented on PR #12391: URL: https://github.com/apache/seatunnel/pull/12391#issuecomment-5825752145
@SeaSand1024 thanks for syncing `dev` and posting the direct job links — that's exactly the evidence needed here. Checked on my side: - The PR diff at `57890813b` is identical to what was reviewed at `0fc63dc5`; the sync (merge `57890813b`) brought in only upstream `dev` commits and touched none of the files this PR changes, so the earlier code review still stands and nothing needs to be re-opened. - `all-connectors-it-2` in run `35870424836` is green on both `107213895744` (JDK 8) and `107213896064` (JDK 11), and `OpengaussCDCIT.testAddFieldWithRestore` no longer fails there, which is the outcome we expected once the branch picked up the current `dev`. - Agreed that `engine-v2-it` stays out of scope for this PR — that failure mode is unrelated to your diff and unaffected by the sync. No remaining asks from me on the previously raised point; the CI gap that was attributable to this branch being behind `dev` is closed. I'll proceed on the green unit-test matrix plus the now-green `all-connectors-it-2`. If anything in CI changes before merge, please drop the run link here as you did this time. <!-- streview-comment:1296 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
