sudeephazra commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-5843964958
I am submitting ffb423c93bf47a87c46c22a2134e151b4aa17e50 from the branch for your review - F1: Done. ADLSConfigValidator.required() returns trimmed values, and ADLSHadoopConf uses it to read the account, container, endpoint, and credentials. The padded account_name and account_key case is covered by a test. - F4: Done. normalizeAuthorityHost() requires HTTPS and rejects user info, paths other than /, queries, and fragments. Tests cover HTTP and malformed or redirected values. - F2: Done. The sink docs say HNS is required for atomic rename and the exactly-once claim. - F3: Done. The docs describe the naming rules, auth exclusivity, and blocked Hadoop property families. The template uses valid account and container placeholders. - F5: Done. The source tables include schema and identify text-only row delimiters. The sink tables identify text-only field delimiters. Both factories expose authority_host, and the English and Chinese tables are aligned. Google Translate did the translation, and I need your help to validate this if you speak the language 😅 - F6: Done. The English and Chinese docs explain that account_key masking is a global core-starter default. - F7: Done. The English source doc lists discovery_mode=ONCE and start_mode=EARLIEST. - F8: Done. The denylist covers ABFS implementation keys and OAuth, SAS, delegation, identity, and shell key-provider families. Tests cover representative provider and class-loading keys. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
