sudeephazra commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-5904653079
@SEZ9 Yes, these are addressed - Trimmed values: [`ADLSConfigValidator.required()` (line 126)](seatunnel-connectors-v2/connector-file/connector-file-adls/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSConfigValidator.java:126) returns value.trim(). [`ADLSHadoopConf` (line 62)](seatunnel-connectors-v2/connector-file/connector-file-adls/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSHadoopConf.java:62) now uses that same helper for account, container, endpoint suffix, shared key, and all OAuth values instead of reading raw configuration values. - Regression coverage: [`usesTrimmedValuesValidatedForSharedKey()` (line 53)](seatunnel-connectors-v2/connector-file/connector-file-adls/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSHadoopConfTest.java:53) covers padded shared-key values. [`configuresOAuthClientCredentials()` (line 72)](connector-file/connector-file-adls/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSHadoopConfTest.java:72) covers padded OAuth values. - HNS documentation: the prerequisite is documented in both the [English sink documentation (line 39)](docs/en/connectors/sink/ADLSFile.md:39) and [Chinese sink documentation (line 31)](docs/zh/connectors/sink/ADLSFile.md:31). Both explain the atomic rename requirement and require tmp_path and path to share a container. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
