sun-9545sunoj commented on PR #12463:
URL: https://github.com/apache/seatunnel/pull/12463#issuecomment-5849501308
Thanks again for the incredibly detailed re-review and for taking the time
to trace those CI flakes down to their root causes! I really appreciate you
verifying everything end-to-end.
I've just pushed an update to wrap up the final items:
1. CI Flakes (Blocker): I've rebased the branch against the absolute
latest dev head. This should give us a clean base and bypass the unrelated
Hudi, OceanBase, and Engine test flakes.
2. Issue 8 (FQN Nit): Good catch. I cleaned up the test file so it now
consistently uses the standard static imports (assertTrue, assertFalse,
Collections.emptyList()) and the simple Column name instead of the fully
qualified names.
3. Issue 9 (Documentation): I've updated the PR description to include a
specific note calling out that sample-sharding.threshold no longer bounds the
sampling path for gap-skewed tables, documenting the performance trade-off for
future maintainers.
Hope for a fully green CI run this time around! Let me know if everything
looks good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
