sun-9545sunoj commented on PR #12463:
URL: https://github.com/apache/seatunnel/pull/12463#issuecomment-5854497426
Thanks for sticking with this PR through these thorough reviews! I genuinely
appreciate the detailed tracing, and you were completely right to call out the
gap in boundary-output assertions.
I’ve just pushed a final update addressing the remaining non-blocking
items:
1. Issue 10 (Boundary Correctness Test): I went with Option A. I added a
new test (testSplitTableIntoChunksBoundaryCorrectnessWithSparseKeys) that feeds
the concrete sparse PK set ({1, 2, 5, 6,100}) into the splitter and asserts the
exact List<ChunkRange> output. It verifies that both the sampling path and
the exact-query fallback path produce correct, gap-free, non-overlapping
boundaries for the keyspace.
2. Issue 11 (Description Nit): I've updated the PR description to reference
the actual test method names.
The branch has also been rebased against the latest apache:dev. I completely
understand the known deterministic flakes (OceanBase TableId serialization) are
a blocker on the CI side until their respective upstream fixes merge.
Thank you again for your patience and for making this patch much more
robust! Let me know if you are happy to
merge this once the upstream CI green-lights
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
