Asthenia0412 commented on PR #12494: URL: https://github.com/apache/seatunnel/pull/12494#issuecomment-5865113720
Follow-up on the review findings: The two blocking stale-generation cases and synchronous cancellation under the service monitor are addressed in the current head. Reset now marks generations before cancelling outside the monitor, and terminal notifications from reset generations are suppressed. The redeploy regression test keeps the old task alive through interruption and verifies the replacement generation remains active. The E2E fixture still does not evict a member from Hazelcast membership; its assertion is scoped to local reset plus master failover, as documented inline in the test. This PR’s `SeaTunnelServer#reset()` handles worker task execution only. Coordinator and slot ownership remain governed by their independent lifecycle paths, and this boundary is now documented at the reset method. Validation: `TaskExecutionServiceTest` passed with the repository CI’s JDK 8 runtime using `./mvnw -pl seatunnel-engine/seatunnel-engine-server -am -Dtest=TaskExecutionServiceTest -Dsurefire.failIfNoSpecifiedTests=false -DskipITs -Dspotless.check.skip=true package`; `spotless:check` also passed for `seatunnel-engine-server`. Could you please re-review the current head? The Build check remains ACTION_REQUIRED pending workflow approval, so I have not changed repository Actions settings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
