zhangshenghang commented on PR #12381: URL: https://github.com/apache/seatunnel/pull/12381#issuecomment-5870904088
Thanks @SEZ9 for the thorough review, and @DanielLeens and @goutamadwant for the source-level analysis and the local reproduction data. I've accepted the consensus from this thread and pushed `b77b3c2cd4`: - **Dropped the `PayPalClientTest` changes entirely.** As laid out in the review (SEZ9's Issue 1, confirmed by the forced-IOException experiment), widening the arrival budget cannot fix a latch that a swallowed `IOException` can skip. The root-cause fix has since landed in `dev` via #12444 (release the latch before the body write), so this PR now carries no PayPal diff at all — the file is byte-identical to `dev`. - **Kept the `FileCollectReaderBehaviorTest` widening** (three `atMost(3, SECONDS)` ceilings → shared `AWAIT_BUDGET_SECONDS = 10`), which SEZ9's conclusion lists as non-blocking, with Issues 2 and 5 understood as pre-existing follow-ups rather than regressions introduced here. I also merged the latest `upstream/dev` into the branch, so the PayPal half is now covered by #12444's fix rather than removed outright. Verified locally: `spotless:apply` clean and `FileCollectReaderBehaviorTest` passes 3/3 on the new head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
