SEZ9 commented on issue #12457: URL: https://github.com/apache/seatunnel/issues/12457#issuecomment-5882718990
Thanks for the update, @nzw921rx. "Update design" on its own doesn't tell reviewers what actually changed, so it's hard to move this forward. Could you edit the STIP body (or post a short changelog here) that maps the revision to the points that were previously raised: 1. **YARN-first v1** — does the updated design now scope the first implementation to YARN only, with Kubernetes kept as a design comparison and a separately reviewed follow-up? If so, please state that explicitly in the STIP and the linked PR description. 2. **ResourceManager placeholders vs. ResourceManagerDriver** — please spell out the migration relationship: which one owns external worker allocation, release, retries, and terminal cleanup, the call sequence between them, and the compatibility boundary. Right now it's still unclear whether we end up with two competing abstractions. 3. **Frozen YARN contract** — please confirm the design now covers submission/rollback ownership, the worker-registration deadline, detached status/cancel semantics, stable Option names and defaults, checkpoint restore identity, and behavior when the AM or a worker exits. A short table or section per item is enough. 4. **Reviewable slices** — please list the intended slices (shared interface + YARN-only launcher/driver first, then MiniYARN/HDFS lifecycle and restore evidence) and link the focused follow-up work, so the linked PR can be reduced accordingly rather than carrying both platforms, distribution, and docs at once. Also, please keep the statement that the existing standalone, Flink, and Spark entrypoints remain unchanged, and avoid describing the linked PR as implemented while its build is still failing. Once the STIP shows those four items concretely, I'll re-review promptly. <!-- streview-comment:1399 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
