DanielLeens commented on issue #12457: URL: https://github.com/apache/seatunnel/issues/12457#issuecomment-5969019851
Classification: D / Zeta Application Mode architecture and lifecycle scope. Thanks for updating the STIP body. The new non-goal for shared or pre-staged YARN distributions is the right boundary: #12460 should continue to use one self-contained archive per submission, while versioned shared artifacts and connector/classloader upgrade semantics belong in a separate STIP. The broader review gate is still not met. The updated Goals, platform architecture, and platform-scope sections still make both YARN and Kubernetes part of the first implementation, and #12460 still carries both provider modules, packaging paths, and E2E suites. That is not the YARN-first, reviewable v1 split requested above. The body also does not provide the requested short changelog or section pointers, so reviewers cannot tell which earlier lifecycle-contract items changed. Please next post a concise revision map and update the linked PR to match it: (1) make the first implementation YARN-only, with Kubernetes retained as a design comparison and separately reviewed follow-up; (2) identify the exact sections that freeze submission/rollback ownership, registration deadline, detached status/cancel behavior, stable option names/defaults, checkpoint-restore identity, and AM/worker exit handling; and (3) state the single ownership boundary between ApplicationResourceManager and ResourceManagerDriver for allocation, release, retries, and terminal cleanup. Until that split is visible in both the STIP and #12460, this remains in design review rather than ready for implementation review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
