SEZ9 commented on PR #12048: URL: https://github.com/apache/seatunnel/pull/12048#issuecomment-5882713431
Thanks for the follow-up and the head update. Understood that `49c2f9059a7e` is now the head and that, per your diff against `56794bc19d3e`, the connector and e2e modules are unchanged, so the earlier items still apply to the same code. **F1 (retention-trimmed checkpoint recovery)** — The quoted recovery paragraph (stop the failing job, start a new one without restoring the old source state, choose `start_mode` explicitly) is exactly the escape hatch F1 asked for. I'd like to see the actual diff introducing that paragraph before marking it resolved; if it's in the current head, a pointer to the change is all that's needed. **F2 (`ServicesResourceTransformer` for the `com.azure` / `io.netty` / `org.apache.qpid.proton` relocations)** — Your comment appears to be cut off partway through this item. Static confirmation that the root shade execution declares the transformer is a good start; what would close this is confirmation that the connector module inherits it rather than overriding the shade execution, ideally with the service-provider entries from the built connector jar showing relocated provider class names. That evidence would need to come from the author or a build. **F3, F4, F6, F7, F8** — The direct pointers for these don't appear in the thread yet. Could they be posted per item (file plus the specific option, validation, or doc statement)? For F3 in particular: the option sensitivity flag, the EntityPath-rejection message, and split/config `toString` handling; for F4: where the transitive Netty/Jackson/Proton versions are pinned or managed. **F5 (EntityPath rejection blocking hub-scoped SAS policies)** — Not covered in the follow-up. This one is a design question for the author: whether the connector should accept an `EntityPath`-bearing connection string (and how it would reconcile it with the configured hub name), or whether rejection is intentional and should be documented. Once F2 and F5 have clear answers and the remaining pointers are posted, I'm happy to do a final pass. <!-- streview-comment:1398 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
