SEZ9 commented on PR #12048: URL: https://github.com/apache/seatunnel/pull/12048#issuecomment-5788235498
@goutamadwant thanks for the update on 3e4ee6d3320e. Checking it against the earlier points: **F6 (prefetch_count >= max_batch_size must fail at job submission):** the factory and runtime sharing Conditions validation is what was asked for, and it lines up with @nzw921rx's inline note that Conditions can be used for verification now that STIP-28 is complete. Could you confirm there is a factory-level test asserting the cross-field violation is rejected at option validation time, not only in the reader/config test? **F3 (no SAS key on any output path):** you mention secret-free EntityPath errors. Could you confirm the tests exercise a connection string carrying a key through all three paths — the option's sensitivity flag, the EntityPath-rejection message, and split/config toString? If any of those is only implicitly covered, please add the assertion. **F2 (ServicesResourceTransformer):** since you note the emulator run is still pending, this one is not yet runtime-verified. Please either post the emulator E2E result once it runs, or share the service-provider entries from the built shaded jar showing the relocated Azure/Netty/Proton providers are merged rather than dropped. **F1, F4, F5, F7, F8:** documenting the operator recovery path, keeping the transitive Netty/Jackson/Proton stance documented, rejecting (not converting) EntityPath connection strings, and documenting the partition-rediscovery / reconnect scope limits is acceptable as a documented-limitation approach for the initial connector. No further change requested there. Could you also confirm that the commits since 386d5c1ea (765fb71b0, 7bb8e3e7, 3e4ee6d3320e) did not touch the files covered by F1–F8? Once that, the F6 factory test, the F3 three-path assertion, and the F2 jar/emulator evidence are on the thread, I'm happy to move forward. <!-- streview-comment:1253 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
