SEZ9 commented on issue #12531:
URL: https://github.com/apache/seatunnel/issues/12531#issuecomment-5882901874

   Thanks for the detailed proposal and prototype. Since this builds on #12506 
(manual SNAPSHOT_VERSION), #12543 and #12501, could you clarify the intended 
merge order and whether this can be reviewed independently once those land? The 
current codebase has no DuckLake-specific code yet, so reviewers will need the 
base PR first.
   
   Please document the restore-compatibility behavior explicitly in the 
connector docs: enabling `ducklake_snapshot_auto` on a checkpoint without 
snapshot state fails the restore, and an unavailable snapshot fails the job 
rather than falling back to current data. A short migration note would help 
users.
   
   Consider opening this as a PR against dev with the DuckLake fixture tests 
included as an e2e/integration module (or clearly marked as skipped when 
DuckLake is unavailable), and note in the PR description that `query` and regex 
`table_list` selections are rejected when the option is enabled.
   
   <!-- streview-comment:1402 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to