NganWave commented on PR #12491: URL: https://github.com/apache/seatunnel/pull/12491#issuecomment-5925695348
Thanks for the review! While updating the docs for this PR, I rechecked the flow through `ParameterSplitter`, `ConfigBuilder`, and downstream `ConfigUtil`. I decided to remove `ParameterException` and tighten the structured check in `ConfigValueUtils`. **Why:** - Splitting is heuristic, so throwing exceptions there risks false positives on valid inputs. - Strict exceptions at that stage break existing configs on upgrade, increasing migration cost. - SeaTunnel users are mostly data engineers and developers who can diagnose type mismatches themselves. - `ConfigUtil` has the full parsing behavior, so errors are more accurate, consistent, and easier to sanitize. - `isStructured` still gates `parseString`, so mismatched inputs are caught downstream rather than silently accepted. Tests cover bracket edge cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
