SEZ9 commented on PR #12460: URL: https://github.com/apache/seatunnel/pull/12460#issuecomment-5945071702
@nzw921rx thanks for the quick turnaround and for the ping. As noted in my latest review, the High items from the earlier round are resolved on the current head. A few follow-ups before we move toward merge: 1. **WIP checkpoint commit.** The earlier head (`0f83be84`) carried the commit `[Improve][Zeta] Refactor application commands and cluster descriptors` with the message "Save the current application-mode refactoring for continued development. Full build and tests are not yet verified." If that commit is still in the branch history, please reword or squash it so we don't ship a "not yet verified" checkpoint. 2. **Architecture rewrite between `ea12ee13` and `0f83be84`.** The submission and master-lifecycle path I reviewed in the first two rounds was replaced rather than modified. Could you add a short note to the PR description explaining why the rewrite was needed and how the new submission/master-lifecycle flow works end to end? That will help future readers and lets us confirm the docs match the final design. 3. **Areas I only skimmed.** I have not yet read in depth the YARN provider bodies, the rewritten `SeatunnelApplicationConfig` / `ApplicationSpecification`, or the two E2E suites beyond their pass/fail status. I'll go through those next; if anything in the YARN path is still incomplete or untested, please call it out now so I don't review it as final. Thanks again for the persistence on this one. <!-- streview-comment:1462 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
