SEZ9 commented on PR #12460: URL: https://github.com/apache/seatunnel/pull/12460#issuecomment-6105177230
Thanks for the quick follow-up, @nzw921rx. Re-checking the latest head (`eba8a95c5241`) against the earlier CHANGES_REQUESTED round at `95113ad9`: the four High items and the Medium items from that round are confirmed fixed in source, and `eba8a95c52` also closes Issues B, C and D from the review at `beef4d1147` and swaps the Arrow import for the shaded Guava one. I don't see a remaining source-level blocker. The screenshots @zhangshenghang asked for are in the description now, which covers that request. Two small asks before this is ready to go, both carried over from the `beef4d1147` review and seconded in the latest pass: 1. **Issue E — serial per-worker deletes** (`ApplicationResourceManager.java:228-230`): the deletes run one after another inside the 60 s stop budget, so a larger worker count can push cleanup past the deadline. Please either issue the deletes concurrently and wait on them collectively, or explain why serial is safe within the budget here. 2. **Public test-only method on the SPI factory** (`KubernetesApplicationClusterDescriptorFactory.java:73-74`): please drop the visibility to package-private (or move the hook into the test) so the test seam doesn't become part of the public surface. Once those two are addressed, please ping me and I'll do a final pass on just that delta. <!-- streview-comment:1671 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
