hutiefang76 commented on PR #12578: URL: https://github.com/apache/seatunnel/pull/12578#issuecomment-5964943021
> Once you confirm the three items above I'm happy to take another look. Confirmed against ec14f3a: 1. `setField` performs the array assignment, then one read in `if (size != 0)` and a conditional `size = 0` write. A fresh row has no cache write. 2. The paragraph was moved out of Source Contract into the shared `Row Data Contract` / `行数据契约` section of the EN/ZH architecture guides. The public setter/getFields/size-overload Javadoc carries the same contract. 3. `testDirectFieldMutationDoesNotInvalidateCachedBytesSize` changes `abc` to `abcdef` through `getFields()` and asserts both overloads still return 3; a top-level `setField` then yields 6. `testNestedFieldMutationDoesNotInvalidateParentCachedBytesSize` asserts the child updates to 6 while both parent overloads remain 3, until `parent.setField` makes the parent estimate 6. Updated the PR description to match the 13-test suite. JMH intervals overlap, so no performance improvement is claimed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
