SEZ9 commented on PR #12556: URL: https://github.com/apache/seatunnel/pull/12556#issuecomment-5976294970
Thanks for the follow-up. I re-read the updated changes and the direction still looks right to me. The core fix is sound: `taskDone()` no longer performs the blocking `updateMetricsContextInImap()` call on the possibly-interrupted `BlockingWorker` thread, and `completeAfterFinalMetrics(...)` builds the terminal `TaskExecutionState` first, hands the Hazelcast invocation to the `seatunnel.final-metrics` daemon threads, and completes the task-group future in `finally` (or inline if the submit itself is rejected). That addresses the `ClosedByInterruptException` / shared-connection problem without letting cancellation stall behind the metrics write. The thread-pool shape blocker from my first round is resolved with the switch to `Executors.newCachedThreadPool(...)`, and the executor is shut down in the service shutdown path. My approval stands; nothing further needed from my side. <!-- streview-comment:1513 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
