DanielLeens commented on PR #12556:
URL: https://github.com/apache/seatunnel/pull/12556#issuecomment-6097956367
Thanks @Asthenia0412, and thanks @SEZ9 for the follow-up. There is no open
question for me on the review threads, and my approval of the source change at
head 434666b060 stands.
One fact in my last review has changed, so I want to correct it. I wrote
that no conflict with dev was reported at that time. GitHub now reports merge
conflicts on this PR. I checked the head against the current dev: the conflict
is in `TaskExecutionServiceTest.java`, where the recent change #12454 touched
the same test file. `TaskExecutionService.java` itself merges cleanly.
Could you please sync with the latest dev and resolve that conflict? In
addition, the apache-side `Build` check is still `action_required` ("Workflow
run detection failed", https://github.com/apache/seatunnel/runs/110581259611),
so no test has run on this PR yet. Pushing the sync commit should also start
the workflow in your fork. If it does not start, please make sure GitHub
Actions is enabled for your fork. Once CI has run, a maintainer can take it
from there.
Happy to help if anything is unclear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
