SEZ9 commented on issue #12613: URL: https://github.com/apache/seatunnel/issues/12613#issuecomment-5988516672
Thanks for digging into this, @goutamadwant — the local reproduction is really helpful. 155.6 minutes for all 22 versions versus 12.9 minutes for current docs plus the latest snapshot clearly explains why the `Build website` job keeps blowing past its 90-minute limit and turning unrelated PR `Build` checks red, and trimming the PR-time check to those two makes sense to me. A few things I'd like to settle before we land the fix: 1. How is "latest snapshot" selected in your change — is it derived automatically (e.g. the newest versioned docs directory) or hard-coded? If hard-coded, please make it automatic so the next release doesn't silently drop coverage or require someone to remember to bump it. 2. Since the older versions will no longer be built on PRs, do we still exercise the full 22-version build anywhere (e.g. a scheduled run or the website repository's own CI)? If not, let's note that trade-off explicitly in the PR description so it's clear where a regression in an older version's docs would be caught. 3. Could you confirm that the 12.9-minute run used exactly the same steps as the CI job and completed successfully, not just faster? A short note of the command sequence in the PR would be enough. Once those are covered I'm happy to review the PR itself. <!-- streview-comment:1536 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
