Vivek1106-04 commented on PR #12511: URL: https://github.com/apache/seatunnel/pull/12511#issuecomment-6011124492
@SEZ9 Thanks for the review. 1. The re-run has finished. Attempt 2 of the fork run passed `engine-v2-it (11)` and the rest of the engine jobs, and `Build` is green on `a691fb195`. 2. The first comment is complete on GitHub; the preview probably cut it off. The sentence continues: "The savepoint case is unchanged, and the cancelled job no longer restarts a pipeline only to cancel it." Issue 4 is covered in the same comment, right after that sentence: https://github.com/apache/seatunnel/pull/12511#issuecomment-5982000557 3. A test already pins the non-cancel branch, in `SavePointTest` rather than `CheckpointErrorRestoreEndTest`. `testSavePointFailureDuringPipelineRestoreWaitEndsTheJob` fails a savepoint while a pipeline is in its restore wait, with the job not cancelling, and asserts the job ends `FAILED`. Without `abandonRestore` that pipeline stays `RUNNING` and the job stays in `DOING_SAVEPOINT`, so the test times out. Together with `testCancelDuringPipelineRestoreWaitEndsTheJobCanceled`, both branches of `abandonRestore` are covered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
