zhang-arvin commented on PR #11844:
URL: https://github.com/apache/seatunnel/pull/11844#issuecomment-6051667738

   @DanielLeens Thanks — both carryover blockers are real and now fixed. Pushed 
head `59ba63638`.
   
   **Issue 1 (missing E2E config)** — added 
`seatunnel-e2e/.../connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_snapshot_only_to_mysql.conf`:
 MySQL-CDC source with `startup.mode = "snapshot-only"`, JDBC sink, `job.mode = 
"BATCH"`. (There was also a hard compile error in this test — 
`MysqlCDCDriverResolver` doesn't exist in the module — replaced with the 
standard `DependencyJar.ofClassName("com.mysql.cj.jdbc.Driver").copyTo(...)` 
container extension used by the sibling ITs, which is why the 
`mysql-cdc-connector-it` job was red.)
   
   **Issue 2 (vacuous test)** — fixed. The test no longer truncates the seeded 
source table; it asserts the source is non-empty, runs `executeJob` 
synchronously and asserts `getExitCode() == 0`, then compares source vs sink.
   
   **Issue 3 (docs)** — fixed EN + ZH: the `stop.mode` note now says it must be 
left unset (or `never`) with `snapshot-only`, otherwise the job fails at 
startup.
   
   **Issue 4 (ORDER BY)** — fixed, both query builders append `order by id`.
   
   **Issue 5 (restore semantics)** — documented the intentional divergence from 
the hybrid restore path in the `getCheckpointCapturedTables` Javadoc.
   
   Verified locally: `connector-cdc-base` installs, the 
`connector-cdc-mysql-e2e` module test-compiles clean, and `spotless:apply` is 
clean. New head `59ba63638`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to