Rangsh commented on issue #12492: URL: https://github.com/apache/seatunnel/issues/12492#issuecomment-6057579748
Thanks @SEZ9 — agreed, I'll treat the points you confirmed as the locked v1 contract and will not start implementation until #12081 is merged and this follow-up is rebased on it. Pinning the two pre-PR points: 1. **Single owner.** The `WALWorkHandler` catch path is the sole owner of the fail-close trip and best-effort `done(false)` for the affected request. The custom Disruptor `ExceptionHandler` is a log + idempotent backstop only: if fail-close is already tripped or the future is already completed, it must not `done(...)` again or race the sticky flag. 2. **Queued APPENDs do not touch the writer.** Once fail-close is tripped, best-effort completion of already-queued APPENDs only completes their futures. It must not re-enter `write(...)` or any other writer state. I'll open the PR against the rebased baseline after #12081 lands, include the safe synthetic `Error` regression, and reference this contract in the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
