ryanmeowy commented on PR #12708: URL: https://github.com/apache/seatunnel/pull/12708#issuecomment-6094300528
The Build failure here is in `elasticsearch-connector-it (11)` and `(17)`, which run outside the modules this PR touches. Both jobs fail on the same three slice tests: ``` [ERROR] ElasticsearchIT.testElasticsearchWithPITSlice:495 iterable [ERROR] ElasticsearchIT.testElasticsearchWithPITSliceQueued:507 iterable [ERROR] ElasticsearchIT.testElasticsearchWithScrollSlice:518 iterable org.opentest4j.AssertionFailedError: iterable lengths differ, expected: <11> but was: <10> ``` These same two jobs fail on dev at the base commit of this PR (`0278a6a74`), in run https://github.com/apache/seatunnel/actions/runs/37927712604, with the same three tests and the same assertion (`Tests run: 116, Failures: 7`). That run has none of my commits in it. Other open PRs (#12705, #12710) currently have a failing Build as well. This PR changes four files under `connector-cdc-mysql` and `connector-cdc-oceanbase` only. The mysql-cdc ITs, the unit tests, spotless and the license check are green. I reran the two failed jobs three times on my fork run, and they fail the same way each time, so it doesn't look like a one-off on my side. While looking at the test code I noticed the three failing tests read the sink index once right after the job finishes and assert immediately, whereas `testElasticsearchWithPIT` at line 464 wraps the same read in `Awaitility` with the 60s refresh timeout. The polling work in #12642 covered the rest of the file but not these three, which would explain why they are the ones failing now. How would you like me to proceed? I can leave this PR as it is and wait for the slice tests to be fixed on dev, or open a separate test-only PR that adds the same waiting to those three tests. I don't think that fix belongs in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
