DanielLeens commented on PR #12638: URL: https://github.com/apache/seatunnel/pull/12638#issuecomment-6097747326
Thanks for the context, @nankeChen75, and sorry for the noise on my side. I had not read the discussion in #9583 before raising the branch question, and that is what I should have checked first. Having now read it: @SEZ9 explicitly asked for a minimal backport of the `sinkActions.isEmpty()` guard based on `2.3.13-release`, scoped to the guard plus a test for the all-tables-filtered case, with both tests confirmed to fail without the guard. This PR does exactly that, and your description already covers the requested confirmations. So the "released-version branch" item in my earlier review should not be treated as a blocker on your side. Whether 2.3.x is still accepting fixes, and whether this is the right line, is a call for the committers, and the guidance in the issue already points to this target. Please consider that item withdrawn as a requirement for you. Where this stands, from my side: - I do not see any source-level blocker in the code or the tests on head `70d4b910c`; my previous technical findings are unchanged (guard is minimal and matches `dev`, both new tests fail without it, `testFilterWithEmptySinkBranch` is rated Stable). - The only remaining gate is CI. The red jobs I looked at earlier (`CoordinatorServiceTest.testMasterNodeActive` in `seatunnel-engine-server`, `Build website`, and several connector ITs) are in code this PR does not touch, while `transform-v2-it-part-2` (where the new IT runs) and `engine-v2-it` passed. A committer-approved re-run of the failed jobs is the realistic next step; there is nothing for you to change in the diff for that. - Optional and non-blocking: since `dev` has the guard but not these two regression tests, a small test-only PR to `dev` would be a nice follow-up so the behavior stays pinned on the main line. Thanks again for the careful repro and the mutation check, this is a very clean backport. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
