chovy-3012 commented on PR #12698: URL: https://github.com/apache/seatunnel/pull/12698#issuecomment-6104487064
Hi @DanielLeens, thanks for the recheck. Both non-blocking items addressed: 1. **Test javadoc / docs wording** — Fixed the javadoc to state `mockConstruction` is used, not a real factory. Added a note in both en/zh docs clarifying that factory-level options fall back to the URI `jms.*` parameter or the ActiveMQ default when not set. Simplified the two invalid-value tests since validation now runs first. 2. **Validate before connecting** — Moved `delivery_mode` / `priority` range checks to the top of the constructor, before `getConnectionFactory()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
